Add customization features: favicon, GA4, header HTML, 404 page #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add custom favicon support (#16) - New faviconUrl option in branding settings - LinkRewriter removes Notion's default favicon links - HeadRewriter adds custom favicon, shortcut icon, and apple-touch-icon - Add Google Analytics 4 built-in support (#14) - New analytics.googleTagId option - Automatic GA4 script injection in HeadRewriter - Add custom HTML header injection (#20) - New customHtml.headerHtml option - BodyRewriter prepends custom HTML at top of body - Add custom 404 page support (#12) - New custom404.notionUrl option - fetchAndApply returns custom Notion page with 404 status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements multiple customization features requested in the following issues:
Features Implemented
Custom Favicon Support (Closes #16) - priority: high
faviconUrloption in branding settingsLinkRewriterremoves Notion's default favicon linksHeadRewriteradds custom favicon, shortcut icon, and apple-touch-iconGoogle Analytics 4 Built-in Support (Closes #14) - priority: medium
analytics.googleTagIdoptionHeadRewriterCustom HTML Header Injection (Closes #20) - priority: medium
customHtml.headerHtmloptionBodyRewriterprepends custom HTML at top of bodyCustom 404 Page Support (Closes #12) - priority: medium
custom404.notionUrloptionfetchAndApplyreturns custom Notion page content with 404 statusUI Changes
All new features are accessible in the Advanced Settings panel:
Testing
npm run build)